From 9df01a4a48f1b554c75db7910c7e2c4587f5dd27 Mon Sep 17 00:00:00 2001
From: Horst Schirmeier <horst.schirmeier@tu-dortmund.de>
Date: Tue, 6 Jan 2015 15:13:05 +0100
Subject: [PATCH] visualfail: off-by-one in getHighlevelCode()
This one omitted mappings to the first static instruction belonging to a
high-level source-code line.
Change-Id: I14427021e61f27a8b029fb56fad2ba813652422a
---
tools/analysis/VisualFAIL/core.php | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/analysis/VisualFAIL/core.php b/tools/analysis/VisualFAIL/core.php
index 688e700a..f0aee3ce 100644
--- a/tools/analysis/VisualFAIL/core.php
+++ b/tools/analysis/VisualFAIL/core.php
@@ -260,7 +260,8 @@ function getHighlevelCode()
$maxFehler[$val] = 0;
}
foreach ($value as $index => $ranges) {
- $InstrMappingAbfrage = "SELECT instr_address, disassemble FROM objdump WHERE variant_id = '" . $_GET['variant_id']. "' AND instr_address > '" . $ranges[0] . "' AND instr_address < '" . $ranges[1] . "' ORDER BY instr_address;";
+ // was ">" instead of ">=" before
+ $InstrMappingAbfrage = "SELECT instr_address, disassemble FROM objdump WHERE variant_id = '" . $_GET['variant_id']. "' AND instr_address >= '" . $ranges[0] . "' AND instr_address < '" . $ranges[1] . "' ORDER BY instr_address;";
$mappingErgebnis = mysql_query($InstrMappingAbfrage);
//Leerzeile
$mapping[$lineNumber] [] = '<br>';
--
GitLab