From 046fa7ae20d2390c65be8eb406efecff15e8b71d Mon Sep 17 00:00:00 2001 From: Ingo Molnar <mingo@kernel.org> Date: Thu, 10 Oct 2013 09:06:21 +0200 Subject: [PATCH] tools/perf/build: Improve the 'stackprotector' feature test Namhyung Kim noticed that the stackprotector testcase was incomplete: > The flag being checked should be -"W"stack-protector instead of > -"f"stack-protector. And the gcc manpage says that -Wstack-protector is > only active when -fstack-protector is active. So the end result should > look like > > $(BUILD) -Werror -fstack-protector -Wstack-protector Add -Wstack-protector. Reported-by: Namhyung Kim <namhyung@kernel.org> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: David Ahern <dsahern@gmail.com> Cc: Jiri Olsa <jolsa@redhat.com> Signed-off-by: Ingo Molnar <mingo@kernel.org> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/config/feature-checks/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/config/feature-checks/Makefile b/tools/perf/config/feature-checks/Makefile index 2eb83467cca2..c70d23ecb64e 100644 --- a/tools/perf/config/feature-checks/Makefile +++ b/tools/perf/config/feature-checks/Makefile @@ -45,7 +45,7 @@ test-stackprotector-all: $(BUILD) -Werror -fstack-protector-all test-stackprotector: - $(BUILD) -Werror -fstack-protector + $(BUILD) -Werror -fstack-protector -Wstack-protector test-fortify-source: $(BUILD) -O2 -Werror -D_FORTIFY_SOURCE=2 -- GitLab