Skip to content
Snippets Groups Projects
  • Frederic Weisbecker's avatar
    cb1955b8
    perf tools: Only display parent field if explictly sorted · cb1955b8
    Frederic Weisbecker authored
    
    We don't need to display the parent field if the parent
    sorting machinery is only used for parent filtering
    (as in "-p foo").
    
    However if parent filtering is used in combination with
    explicit parent sorting ( -s parent), we want to
    display it.
    
    Result with:
    
      perf report -p kernel_thread -s parent
    
    Before:
    
     # Overhead  Parent symbol
     # ........  .............
     #
         0.07%
                |
                --- ioread8
                    ata_sff_check_status
                    ata_sff_tf_load
                    ata_sff_qc_issue
                    ata_bmdma_qc_issue
                    ata_qc_issue
                    ata_scsi_translate
                    ata_scsi_queuecmd
                    scsi_dispatch_cmd
                    scsi_request_fn
                    __blk_run_queue
                    __make_request
                    generic_make_request
                    submit_bio
                    submit_bh
                    journal_submit_commit_record
                    jbd2_journal_commit_transaction
                    kjournald2
                    kthread
                    kernel_thread_helpe
    
    After:
    
     # Overhead  Parent symbol
     # ........  .............
     #
         0.07%  kernel_thread_helper
                |
                --- ioread8
                    ata_sff_check_status
                    ata_sff_tf_load
                    ata_sff_qc_issue
                    ata_bmdma_qc_issue
                    ata_qc_issue
                    ata_scsi_translate
                    ata_scsi_queuecmd
                    scsi_dispatch_cmd
                    scsi_request_fn
                    __blk_run_queue
                    __make_request
                    generic_make_request
                    submit_bio
                    submit_bh
                    journal_submit_commit_record
                    jbd2_journal_commit_transaction
                    kjournald2
                    kthread
                    kernel_thread_helper
    
    Signed-off-by: default avatarFrederic Weisbecker <fweisbec@gmail.com>
    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Stephane Eranian <eranian@google.com>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Sam Liao <phyomh@gmail.com>
    cb1955b8
    History
    perf tools: Only display parent field if explictly sorted
    Frederic Weisbecker authored
    
    We don't need to display the parent field if the parent
    sorting machinery is only used for parent filtering
    (as in "-p foo").
    
    However if parent filtering is used in combination with
    explicit parent sorting ( -s parent), we want to
    display it.
    
    Result with:
    
      perf report -p kernel_thread -s parent
    
    Before:
    
     # Overhead  Parent symbol
     # ........  .............
     #
         0.07%
                |
                --- ioread8
                    ata_sff_check_status
                    ata_sff_tf_load
                    ata_sff_qc_issue
                    ata_bmdma_qc_issue
                    ata_qc_issue
                    ata_scsi_translate
                    ata_scsi_queuecmd
                    scsi_dispatch_cmd
                    scsi_request_fn
                    __blk_run_queue
                    __make_request
                    generic_make_request
                    submit_bio
                    submit_bh
                    journal_submit_commit_record
                    jbd2_journal_commit_transaction
                    kjournald2
                    kthread
                    kernel_thread_helpe
    
    After:
    
     # Overhead  Parent symbol
     # ........  .............
     #
         0.07%  kernel_thread_helper
                |
                --- ioread8
                    ata_sff_check_status
                    ata_sff_tf_load
                    ata_sff_qc_issue
                    ata_bmdma_qc_issue
                    ata_qc_issue
                    ata_scsi_translate
                    ata_scsi_queuecmd
                    scsi_dispatch_cmd
                    scsi_request_fn
                    __blk_run_queue
                    __make_request
                    generic_make_request
                    submit_bio
                    submit_bh
                    journal_submit_commit_record
                    jbd2_journal_commit_transaction
                    kjournald2
                    kthread
                    kernel_thread_helper
    
    Signed-off-by: default avatarFrederic Weisbecker <fweisbec@gmail.com>
    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Stephane Eranian <eranian@google.com>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Sam Liao <phyomh@gmail.com>