xen/grant-table: Avoid m2p_override during mapping
The grant mapping API does m2p_override unnecessarily: only gntdev needs it, for blkback and future netback patches it just cause a lock contention, as those pages never go to userspace. Therefore this series does the following: - the original functions were renamed to __gnttab_[un]map_refs, with a new parameter m2p_override - based on m2p_override either they follow the original behaviour, or just set the private flag and call set_phys_to_machine - gnttab_[un]map_refs are now a wrapper to call __gnttab_[un]map_refs with m2p_override false - a new function gnttab_[un]map_refs_userspace provides the old behaviour It also removes a stray space from page.h and change ret to 0 if XENFEAT_auto_translated_physmap, as that is the only possible return value there. v2: - move the storing of the old mfn in page->index to gnttab_map_refs - move the function header update to a separate patch v3: - a new approach to retain old behaviour where it needed - squash the patches into one v4: - move out the common bits from m2p* functions, and pass pfn/mfn as parameter - clear page->private before doing anything with the page, so m2p_find_override won't race with this v5: - change return value handling in __gnttab_[un]map_refs - remove a stray space in page.h - add detail why ret = 0 now at some places v6: - don't pass pfn to m2p* functions, just get it locally Signed-off-by:Zoltan Kiss <zoltan.kiss@citrix.com> Suggested-by:
David Vrabel <david.vrabel@citrix.com> Acked-by:
David Vrabel <david.vrabel@citrix.com> Acked-by:
Stefano Stabellini <stefano.stabellini@eu.citrix.com> Signed-off-by:
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Showing
- arch/x86/include/asm/xen/page.h 3 additions, 2 deletionsarch/x86/include/asm/xen/page.h
- arch/x86/xen/p2m.c 2 additions, 15 deletionsarch/x86/xen/p2m.c
- drivers/block/xen-blkback/blkback.c 6 additions, 9 deletionsdrivers/block/xen-blkback/blkback.c
- drivers/xen/gntdev.c 8 additions, 5 deletionsdrivers/xen/gntdev.c
- drivers/xen/grant-table.c 76 additions, 13 deletionsdrivers/xen/grant-table.c
- include/xen/grant_table.h 6 additions, 2 deletionsinclude/xen/grant_table.h
Loading
Please register or sign in to comment