Skip to content
Snippets Groups Projects
Commit 09a228e7 authored by Axel Lin's avatar Axel Lin Committed by Mark Brown
Browse files

regulator: tps65090: Fix using wrong dev argument for calling of_regulator_match


The dev parameter is the device requesting the data.
In this case it should be &pdev->dev rather than pdev->dev.parent.

The dev parameter is used to call devm_kzalloc in of_get_regulator_init_data(),
which means this fixes a memory leak because the memory is allocated every time
probe() is called, thus it should be freed when this driver is unloaded.

Signed-off-by: default avatarAxel Lin <axel.lin@ingics.com>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
parent 6c7a7a0e
No related branches found
No related tags found
No related merge requests found
...@@ -186,7 +186,7 @@ static struct tps65090_platform_data *tps65090_parse_dt_reg_data( ...@@ -186,7 +186,7 @@ static struct tps65090_platform_data *tps65090_parse_dt_reg_data(
return ERR_PTR(-ENODEV); return ERR_PTR(-ENODEV);
} }
ret = of_regulator_match(pdev->dev.parent, regulators, tps65090_matches, ret = of_regulator_match(&pdev->dev, regulators, tps65090_matches,
ARRAY_SIZE(tps65090_matches)); ARRAY_SIZE(tps65090_matches));
if (ret < 0) { if (ret < 0) {
dev_err(&pdev->dev, dev_err(&pdev->dev,
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment