-
- Downloads
perf hist: Introduce hists class and move lots of methods to it
In cbbc79a5 we introduced support for multiple events by introducing a new "event_stat_id" struct and then made several perf_session methods receive a point to it instead of a pointer to perf_session, and kept the event_stats and hists rb_tree in perf_session. While working on the new newt based browser, I realised that it would be better to introduce a new class, "hists" (short for "histograms"), renaming the "event_stat_id" struct and the perf_session methods that were really "hists" methods, as they manipulate only struct hists members, not touching anything in the other perf_session members. Other optimizations, such as calculating the maximum lenght of a symbol name present in an hists instance will be possible as we add them, avoiding a re-traversal just for finding that information. The rationale for the name "hists" to replace "event_stat_id" is that we may have multiple sets of hists for the same event_stat id, as, for instance, the 'perf diff' tool has, so event stat id is not what characterizes what this struct and the functions that manipulate it do. Cc: Eric B Munson <ebmunson@us.ibm.com> Cc: Frédéric Weisbecker <fweisbec@gmail.com> Cc: Mike Galbraith <efault@gmx.de> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Tom Zanussi <tzanussi@gmail.com> LKML-Reference: <new-submission> Signed-off-by:Arnaldo Carvalho de Melo <acme@redhat.com>
Showing
- tools/perf/builtin-annotate.c 8 additions, 9 deletionstools/perf/builtin-annotate.c
- tools/perf/builtin-diff.c 23 additions, 27 deletionstools/perf/builtin-diff.c
- tools/perf/builtin-report.c 35 additions, 36 deletionstools/perf/builtin-report.c
- tools/perf/builtin-trace.c 1 addition, 1 deletiontools/perf/builtin-trace.c
- tools/perf/util/event.c 1 addition, 1 deletiontools/perf/util/event.c
- tools/perf/util/event.h 0 additions, 14 deletionstools/perf/util/event.h
- tools/perf/util/hist.c 41 additions, 51 deletionstools/perf/util/hist.c
- tools/perf/util/hist.h 27 additions, 21 deletionstools/perf/util/hist.h
- tools/perf/util/session.c 1 addition, 1 deletiontools/perf/util/session.c
- tools/perf/util/session.h 9 additions, 3 deletionstools/perf/util/session.h
Loading
Please register or sign in to comment