x86 idle: remove 32-bit-only "no-hlt" parameter, hlt_works_ok flag
Remove 32-bit x86 a cmdline param "no-hlt",
and the cpuinfo_x86.hlt_works_ok that it sets.
If a user wants to avoid HLT, then "idle=poll"
is much more useful, as it avoids invocation of HLT
in idle, while "no-hlt" failed to do so.
Indeed, hlt_works_ok was consulted in only 3 places.
First, in /proc/cpuinfo where "hlt_bug yes"
would be printed if and only if the user booted
the system with "no-hlt" -- as there was no other code
to set that flag.
Second, check_hlt() would not invoke halt() if "no-hlt"
were on the cmdline.
Third, it was consulted in stop_this_cpu(), which is invoked
by native_machine_halt()/reboot_interrupt()/smp_stop_nmi_callback() --
all cases where the machine is being shutdown/reset.
The flag was not consulted in the more frequently invoked
play_dead()/hlt_play_dead() used in processor offline and suspend.
Since Linux-3.0 there has been a run-time notice upon "no-hlt" invocations
indicating that it would be removed in 2012.
Signed-off-by:
Len Brown <len.brown@intel.com>
Cc: x86@kernel.org
Showing
- Documentation/kernel-parameters.txt 0 additions, 4 deletionsDocumentation/kernel-parameters.txt
- arch/x86/include/asm/processor.h 0 additions, 10 deletionsarch/x86/include/asm/processor.h
- arch/x86/kernel/cpu/bugs.c 0 additions, 27 deletionsarch/x86/kernel/cpu/bugs.c
- arch/x86/kernel/cpu/proc.c 0 additions, 2 deletionsarch/x86/kernel/cpu/proc.c
- arch/x86/kernel/process.c 2 additions, 4 deletionsarch/x86/kernel/process.c
- arch/x86/xen/setup.c 0 additions, 3 deletionsarch/x86/xen/setup.c
Loading
Please register or sign in to comment