Skip to content
Snippets Groups Projects
Commit 2c7d132a authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

ACPI / PM: Only set power states of devices that are power manageable


Make acpi_device_set_power() check if the given device is power
manageable before checking if the given power state is valid for that
device.  Otherwise it will print that "Device does not support" that
power state into the kernel log, which may not make sense for some
power states (D0 and D3cold are supported by all devices by
definition).

Tested-by: default avatarYinghai Lu <yinghai@kernel.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 5ae90d8e
No related branches found
No related tags found
No related merge requests found
...@@ -159,7 +159,8 @@ int acpi_device_set_power(struct acpi_device *device, int state) ...@@ -159,7 +159,8 @@ int acpi_device_set_power(struct acpi_device *device, int state)
int result = 0; int result = 0;
bool cut_power = false; bool cut_power = false;
if (!device || (state < ACPI_STATE_D0) || (state > ACPI_STATE_D3_COLD)) if (!device || !device->flags.power_manageable
|| (state < ACPI_STATE_D0) || (state > ACPI_STATE_D3_COLD))
return -EINVAL; return -EINVAL;
/* Make sure this is a valid target state */ /* Make sure this is a valid target state */
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment