Skip to content
Snippets Groups Projects
Commit 31304165 authored by Torsten Kaiser's avatar Torsten Kaiser Committed by David S. Miller
Browse files

net: Fix misplaced parenthesis in virtio_net.c


Commit 2e57b79c misplaced its
parenthesis and now tx_fifo_errors will only be incremented if an
ENOMEM error is not written to the syslog.

Correct the parenthesis and indentation to the original goal of
counting all non ENOMEM errors and ratelimiting only the messages.

Signed-of-by: default avatarTorsten Kaiser <just.for.lkml@googlemail.com>

Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 89eb06f1
No related merge requests found
......@@ -626,16 +626,15 @@ static netdev_tx_t start_xmit(struct sk_buff *skb, struct net_device *dev)
/* This can happen with OOM and indirect buffers. */
if (unlikely(capacity < 0)) {
if (likely(capacity == -ENOMEM)) {
if (net_ratelimit()) {
if (net_ratelimit())
dev_warn(&dev->dev,
"TX queue failure: out of memory\n");
} else {
} else {
dev->stats.tx_fifo_errors++;
if (net_ratelimit())
dev_warn(&dev->dev,
"Unexpected TX queue failure: %d\n",
capacity);
}
}
dev->stats.tx_dropped++;
kfree_skb(skb);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment