-
- Downloads
net: ipv4: fix RCU races on dst refcounts
commit c6cffba4 (ipv4: Fix input route performance regression.) added various fatal races with dst refcounts. crashes happen on tcp workloads if routes are added/deleted at the same time. The dst_free() calls from free_fib_info_rcu() are clearly racy. We need instead regular dst refcounting (dst_release()) and make sure dst_release() is aware of RCU grace periods : Add DST_RCU_FREE flag so that dst_release() respects an RCU grace period before dst destruction for cached dst Introduce a new inet_sk_rx_dst_set() helper, using atomic_inc_not_zero() to make sure we dont increase a zero refcount (On a dst currently waiting an rcu grace period before destruction) rt_cache_route() must take a reference on the new cached route, and release it if was not able to install it. With this patch, my machines survive various benchmarks. Signed-off-by:Eric Dumazet <edumazet@google.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
Showing
- include/net/dst.h 1 addition, 6 deletionsinclude/net/dst.h
- include/net/inet_sock.h 13 additions, 0 deletionsinclude/net/inet_sock.h
- net/core/dst.c 21 additions, 5 deletionsnet/core/dst.c
- net/decnet/dn_route.c 6 additions, 0 deletionsnet/decnet/dn_route.c
- net/ipv4/fib_semantics.c 2 additions, 2 deletionsnet/ipv4/fib_semantics.c
- net/ipv4/route.c 4 additions, 12 deletionsnet/ipv4/route.c
- net/ipv4/tcp_input.c 1 addition, 2 deletionsnet/ipv4/tcp_input.c
- net/ipv4/tcp_ipv4.c 6 additions, 6 deletionsnet/ipv4/tcp_ipv4.c
- net/ipv4/tcp_minisocks.c 1 addition, 2 deletionsnet/ipv4/tcp_minisocks.c
Loading
Please register or sign in to comment