[PATCH] uml: umid cleanup
This patch cleans up the umid code: - The only_if_set argument to get_umid is gone. - get_umid returns an empty string rather than NULL if there is no umid. - umid_is_random is gone since its users went away. - Some printfs were turned into printks because the code runs late enough that printk is working. - Error paths were cleaned up. - Some functions now return an error and let the caller print the error message rather than printing it themselves. This eliminates the practice of passing a pointer to printf or printk in, depending on where in the boot process we are. - Major tidying of not_dead_yet - mostly error path cleanup, plus a comment explaining why it doesn't react to errors the way you might expect. - Calls to os_* interfaces that were moved under os are changed back to their native libc forms. - snprintf, strlcpy, and their bounds-checking friends are used more often, replacing by-hand bounds checking in some places. Signed-off-by:Jeff Dike <jdike@addtoit.com> Cc: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it> Signed-off-by:
Andrew Morton <akpm@osdl.org> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
Showing
- arch/um/drivers/line.c 2 additions, 2 deletionsarch/um/drivers/line.c
- arch/um/include/os.h 2 additions, 2 deletionsarch/um/include/os.h
- arch/um/include/user_util.h 0 additions, 1 deletionarch/um/include/user_util.h
- arch/um/kernel/um_arch.c 2 additions, 2 deletionsarch/um/kernel/um_arch.c
- arch/um/kernel/umid.c 4 additions, 8 deletionsarch/um/kernel/umid.c
- arch/um/os-Linux/umid.c 154 additions, 111 deletionsarch/um/os-Linux/umid.c
Loading
Please register or sign in to comment