bpf: do not use reciprocal divide
At first Jakub Zawadzki noticed that some divisions by reciprocal_divide were not correct. (off by one in some cases) http://www.wireshark.org/~darkjames/reciprocal-buggy.c He could also show this with BPF: http://www.wireshark.org/~darkjames/set-and-dump-filter-k-bug.c The reciprocal divide in linux kernel is not generic enough, lets remove its use in BPF, as it is not worth the pain with current cpus. Signed-off-by:Eric Dumazet <edumazet@google.com> Reported-by:
Jakub Zawadzki <darkjames-ws@darkjames.pl> Cc: Mircea Gherzan <mgherzan@gmail.com> Cc: Daniel Borkmann <dxchgb@gmail.com> Cc: Hannes Frederic Sowa <hannes@stressinduktion.org> Cc: Matt Evans <matt@ozlabs.org> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> Cc: Heiko Carstens <heiko.carstens@de.ibm.com> Cc: David S. Miller <davem@davemloft.net> Signed-off-by:
David S. Miller <davem@davemloft.net>
Showing
- arch/arm/net/bpf_jit_32.c 3 additions, 3 deletionsarch/arm/net/bpf_jit_32.c
- arch/powerpc/net/bpf_jit_comp.c 4 additions, 3 deletionsarch/powerpc/net/bpf_jit_comp.c
- arch/s390/net/bpf_jit_comp.c 12 additions, 5 deletionsarch/s390/net/bpf_jit_comp.c
- arch/sparc/net/bpf_jit_comp.c 14 additions, 3 deletionsarch/sparc/net/bpf_jit_comp.c
- arch/x86/net/bpf_jit_comp.c 10 additions, 4 deletionsarch/x86/net/bpf_jit_comp.c
- net/core/filter.c 2 additions, 28 deletionsnet/core/filter.c
Loading
Please register or sign in to comment