[TCP]: Move sack_ok access to obviously named funcs & cleanup
Previously code had IsReno/IsFack defined as macros that were local to tcp_input.c though sack_ok field has user elsewhere too for the same purpose. This changes them to static inlines as preferred according the current coding style and unifies the access to sack_ok across multiple files. Magic bitops of sack_ok for FACK and DSACK are also abstracted to functions with appropriate names. Note: - One sack_ok = 1 remains but that's self explanary, i.e., it enables sack - Couple of !IsReno cases are changed to tcp_is_sack - There were no users for IsDSack => I dropped it Signed-off-by:Ilpo Järvinen <ilpo.jarvinen@helsinki.fi> Signed-off-by:
David S. Miller <davem@davemloft.net>
Showing
- include/net/tcp.h 28 additions, 0 deletionsinclude/net/tcp.h
- net/ipv4/tcp.c 1 addition, 1 deletionnet/ipv4/tcp.c
- net/ipv4/tcp_input.c 46 additions, 36 deletionsnet/ipv4/tcp_input.c
- net/ipv4/tcp_minisocks.c 1 addition, 1 deletionnet/ipv4/tcp_minisocks.c
- net/ipv4/tcp_output.c 3 additions, 3 deletionsnet/ipv4/tcp_output.c
- net/ipv4/tcp_timer.c 1 addition, 1 deletionnet/ipv4/tcp_timer.c
Loading
Please register or sign in to comment