-
- Downloads
net: dont hold rtnl mutex during netlink dump callbacks
Four years ago, Patrick made a change to hold rtnl mutex during netlink dump callbacks. I believe it was a wrong move. This slows down concurrent dumps, making good old /proc/net/ files faster than rtnetlink in some situations. This occurred to me because one "ip link show dev ..." was _very_ slow on a workload adding/removing network devices in background. All dump callbacks are able to use RCU locking now, so this patch does roughly a revert of commits : 1c2d670f : [RTNETLINK]: Hold rtnl_mutex during netlink dump callbacks 6313c1e0 : [RTNETLINK]: Remove unnecessary locking in dump callbacks This let writers fight for rtnl mutex and readers going full speed. It also takes care of phonet : phonet_route_get() is now called from rcu read section. I renamed it to phonet_route_get_rcu() Signed-off-by:Eric Dumazet <eric.dumazet@gmail.com> Cc: Patrick McHardy <kaber@trash.net> Cc: Remi Denis-Courmont <remi.denis-courmont@nokia.com> Acked-by:
Stephen Hemminger <shemminger@vyatta.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
Showing
- include/net/phonet/pn_dev.h 1 addition, 1 deletioninclude/net/phonet/pn_dev.h
- net/bridge/br_netlink.c 4 additions, 3 deletionsnet/bridge/br_netlink.c
- net/core/fib_rules.c 2 additions, 1 deletionnet/core/fib_rules.c
- net/core/rtnetlink.c 5 additions, 7 deletionsnet/core/rtnetlink.c
- net/decnet/dn_dev.c 6 additions, 4 deletionsnet/decnet/dn_dev.c
- net/ipv6/ip6_fib.c 3 additions, 1 deletionnet/ipv6/ip6_fib.c
- net/phonet/pn_dev.c 1 addition, 5 deletionsnet/phonet/pn_dev.c
- net/phonet/pn_netlink.c 3 additions, 1 deletionnet/phonet/pn_netlink.c
Loading
Please register or sign in to comment